Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dircolors: add page #2422

Merged
merged 3 commits into from
Oct 12, 2018
Merged

dircolors: add page #2422

merged 3 commits into from
Oct 12, 2018

Conversation

MasterOdin
Copy link
Collaborator

@MasterOdin MasterOdin commented Oct 9, 2018

Page from #2213


  • The page (if new), does not already exist in the repo.

  • The page (if new), has been added to the correct platform folder:
    common/ if it's common to all platforms, linux/ if it's Linux-specific, and so on.

  • The page has 8 or fewer examples.

  • The PR is appropriately titled:
    <command name>: add page for new pages, or <command name>: <description of changes> for pages being edited.

  • The page follows the contributing guidelines.

@owenvoke owenvoke added the new command Issues requesting creation of a new page. label Oct 9, 2018

- Output commands to set LS_COLOR for C shell:

`dircolors -c-shell`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this command missing an extra dash -?


`dircolors {{file}}`

- Output commands to set LS_COLOR for Bourne shell:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to repeat "to set LS_COLOR" after the 2nd time

@@ -0,0 +1,23 @@
# dircolors

> Output commands to set the LS_COLOR environment variable and style ls, dir, etc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ls and dir in backticks

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me! Thanks, @MasterOdin 😺

Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@owenvoke owenvoke merged commit 374c403 into tldr-pages:master Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants